Tests for tenant restore progress; definition of API types; Fix lints #68
Conversation
api/v1alpha1/obtenant_types.go
Outdated
| //+kubebuilder:default=PRIMARY | ||
| TenantRole constants.TenantRole `json:"tenantRole,omitempty"` | ||
| Source *TenantSourceSpec `json:"source,omitempty"` | ||
| Credentials []corev1.SecretReference `json:"credentials,omitempty"` |
There was a problem hiding this comment.
It's better to specify certain users when create tenant
There was a problem hiding this comment.
Maybe it's ok to store users' information in credentials.
There was a problem hiding this comment.
it's ok, but certain users must be specified, like root and standbyro
There was a problem hiding this comment.
Users' credentials in tenant will be implemented on next step. Some designs are not clear now, maybe user management will be put in OBTenantOperation CR.
I decide to focus on tenant restore first :)
|
|
||
| type OBTenantOpChangePwdSpec struct { | ||
| Tenant string `json:"tenant"` | ||
| SecretRef corev1.SecretReference `json:"secretRef"` |
There was a problem hiding this comment.
what will be stored in secret, username and password?
There was a problem hiding this comment.
Username and password will be here, it's possible to contain other information. Designs for tenant credentials are in pending, now they are just placeholders here hahah.
powerfooI
changed the title
Summary
Add test cases for tenant restore and make them pass
Create API type OBTenantOperation for tenants tiny jobs
Complete API type definitions according to design draft
Update
.golangci.yaml, disableunusedandgosimplelinters andexported,struct-tag,var-naming,comment-spacingsandunused-receiver5 rules ofrevivelinter.Fix other lint errors
Install golangci-lint with Makefile target