Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add api definitions for analyze alert #560

Merged
merged 3 commits into from
Sep 5, 2024

Conversation

chris-sun-star
Copy link
Member

Summary

add api definitions for analyze alert

Solution Description

// @Accept application/json
// @Produce application/json
// @Param body body alert.AnalyzeParam true "alert analyze param"
// @Success 200 object response.APIResponse{data=[]job.Job}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The response should be job.Job instead of []job.Job

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yes, forgot to change this

change response type
Copy link
Collaborator

@powerfooI powerfooI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@powerfooI powerfooI merged commit 534fb8d into oceanbase:master Sep 5, 2024
7 checks passed
@chris-sun-star chris-sun-star deleted the integrate-obdiag branch September 9, 2024 02:53
lizzy-0323 pushed a commit to lizzy-0323/ob-operator that referenced this pull request Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants