Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce read permission if write permission is on #522

Merged
merged 2 commits into from
Aug 22, 2024
Merged

Enforce read permission if write permission is on #522

merged 2 commits into from
Aug 22, 2024

Conversation

powerfooI
Copy link
Collaborator

Summary

  1. Let read request go if the subject has write permission for that object
  2. Updated test cases for rbac module

@powerfooI powerfooI added the dashboard The issue or PR is related to oceanbase dashboard label Aug 22, 2024
@powerfooI powerfooI self-assigned this Aug 22, 2024
chris-sun-star
chris-sun-star approved these changes Aug 22, 2024
View reviewed changes
Copy link
Member

@chris-sun-star chris-sun-star left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chris-sun-star chris-sun-star merged commit 20e250b into oceanbase:master Aug 22, 2024
7 checks passed
@powerfooI powerfooI deleted the fix/ac-write-over-read branch August 22, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris-sun-star chris-sun-star chris-sun-star approved these changes

Assignees

@powerfooI powerfooI

Labels
dashboard The issue or PR is related to oceanbase dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@powerfooI @chris-sun-star