Skip to content

Commit

Permalink
updating cran comments
Browse files Browse the repository at this point in the history
  • Loading branch information
osorensen committed Mar 12, 2024
1 parent dcf9664 commit 5163e27
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@
## Resubmission Note

UPDATE: The original resubmission did not fix a valgrind error. We have reproduced the error and fixed it.

This is a resubmission, fixing issues with "clang-UBSAN", "gcc-UBSAN", and "valgrind". We have reproduced the errors using the Docker images rocker/r-devel-san, and made the necessary changes.

There are also two failing unit tests on noLD. We believe these to be cause be differences in floating point numbers, since the test expectations are based on values after running thousands of steps of an MCMC algorithm. We have added testthat::skip_on_cran() to the two tests in question.
This is a resubmission, fixing a failing unit test on noLD and containing a large number of new features.


## Test Environments
Expand Down

0 comments on commit 5163e27

Please sign in to comment.