[MLCUDDIDL] supports 5.0 by removing modules #28849
Open
+130
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mlcuddidl is a binding for cudd (BDD) which added some interesting functionalities in the C code. It went as far as letting the user put OCaml values as leaf of a BDD, so inside a C datastructure. This require some expert (god?) level collaboration with the runtime. The massive change of the runtime for ocaml 5.0 makes those juggling even more complicated.
This PR removes, only for OCaml >= 5.0, the problematic modules, so that the users can still use the usual BDD datastructure.
I'm not the maintainer which is @nberth , but he seems to be busy: https://framagit.org/nberth/mlcuddidl/-/issues/2