Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade OCamlformat to 0.26.1 #997

Merged
merged 4 commits into from
Dec 11, 2023
Merged

Conversation

Julow
Copy link
Collaborator

@Julow Julow commented Sep 12, 2023

The aim of this preview is to gather feedback.

This is a bug-fix release and is compatible with the slightly changed let-binding syntax in OCaml 5.1.
Changelog can be found here: https://github.com/ocaml-ppx/ocamlformat/blob/main/CHANGES.md

@Julow Julow force-pushed the preview-ocamlformat-0.26.1 branch from 44d11c3 to 0e6b74c Compare September 12, 2023 12:47
Copy link
Contributor

@trefis trefis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Julow Julow marked this pull request as draft September 13, 2023 09:58
@Julow
Copy link
Collaborator Author

Julow commented Sep 13, 2023

Not too fast, it's not released yet :)

@trefis
Copy link
Contributor

trefis commented Sep 13, 2023

Don't worry, I wasn't going to merge :)

@jonludlam
Copy link
Member

All looks good to me.

@Julow Julow force-pushed the preview-ocamlformat-0.26.1 branch from 0e6b74c to 13aef23 Compare September 15, 2023 08:58
@Julow Julow force-pushed the preview-ocamlformat-0.26.1 branch from 13aef23 to c366293 Compare September 26, 2023 08:30
@Julow Julow changed the title Preview ocamlformat 0.26.1 Upgrade OCamlformat to 0.26.1 Sep 26, 2023
@Julow Julow marked this pull request as ready for review September 26, 2023 08:35
@Julow
Copy link
Collaborator Author

Julow commented Sep 26, 2023

OCamlformat has been released 1 week ago, this is ready for merging.

@EmileTrotignon
Copy link
Collaborator

Lets make the CI green again and merge

@EmileTrotignon EmileTrotignon added this to the 2.4.0 milestone Dec 5, 2023
@Julow
Copy link
Collaborator Author

Julow commented Dec 5, 2023

I'll rebase and merge this once all the PRs for 2.4 are merged.

@Julow Julow force-pushed the preview-ocamlformat-0.26.1 branch from 0486b50 to a14d797 Compare December 11, 2023 12:25
@Julow Julow added the no changelog This pull request does not need a changelog entry label Dec 11, 2023
@Julow Julow merged commit d2fa859 into ocaml:master Dec 11, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog This pull request does not need a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants