Safer file handling #1320
Merged
Safer file handling #1320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panglesd
approved these changes
Feb 26, 2025
| @@ -79,4 +79,44 @@ module Tree = Tree | |||
| module Forest = Tree.Forest | |||
| module Json = Json | |||
|
|
|||
| module Io_utils = struct | |||
| let _with_resource res ~close f = | |||
There was a problem hiding this comment.
Is this starting with an underscore to indicate it's not for use outside of the module?
There was a problem hiding this comment.
Exactly. This avoids writing a signature to abstract this one function while the others are trivial.
There was a problem hiding this comment.
I just added some documentation to the module to make it easier to read without an interface.
Input or output channels used for marshalling were often left unclosed. This can cause resource leaks when a piece of code that was once run once is suddenly called multiple times.
This adds safe function for reading from and writing to files and replaces code that did unsafe resource manipulations.
Julow
force-pushed
the
safe_file_handling
branch
from
ab3aa8e to
21826bb
Compare
|
Thanks @Julow ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On top of #1315
Remove many misuses of input and output channels.