-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a tag to declare the order of children #1243
Merged
Merged
+192
−100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panglesd
force-pushed
the
frontmatter-tags
branch
2 times, most recently
from
November 12, 2024 12:53
0f07e7f
to
63f5caa
Compare
jonludlam
force-pushed
the
frontmatter-tags
branch
2 times, most recently
from
November 13, 2024 18:59
6867e54
to
f258cd9
Compare
jonludlam
added
the
no changelog
This pull request does not need a changelog entry
label
Nov 13, 2024
panglesd
force-pushed
the
frontmatter-tags
branch
from
November 14, 2024 09:51
f258cd9
to
8c2b5fc
Compare
panglesd
added a commit
to panglesd/odoc
that referenced
this pull request
Nov 14, 2024
panglesd
removed
the
no changelog
This pull request does not need a changelog entry
label
Nov 14, 2024
gpetiot
reviewed
Nov 15, 2024
gpetiot
reviewed
Nov 15, 2024
panglesd
force-pushed
the
frontmatter-tags
branch
from
November 15, 2024 14:05
97eddcb
to
9094191
Compare
gpetiot
approved these changes
Nov 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now!
Julow
approved these changes
Nov 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good :) I particularly like that the frontmatter tags don't end up in the model.
jonludlam
force-pushed
the
frontmatter-tags
branch
from
November 18, 2024 11:33
9094191
to
4fec2b2
Compare
Thanks! |
jonludlam
pushed a commit
that referenced
this pull request
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, it is:
(The tag expect a single paragraph containing only words and whitespace)
Based on #1239.