Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a tag to declare the order of children #1243

Merged
merged 8 commits into from
Nov 18, 2024

Conversation

panglesd
Copy link
Collaborator

Currently, it is:

@children_order foo    bar dir/ baz
             boo

(The tag expect a single paragraph containing only words and whitespace)

Based on #1239.

@panglesd panglesd force-pushed the frontmatter-tags branch 2 times, most recently from 0f07e7f to 63f5caa Compare November 12, 2024 12:53
@jonludlam jonludlam force-pushed the frontmatter-tags branch 2 times, most recently from 6867e54 to f258cd9 Compare November 13, 2024 18:59
@jonludlam jonludlam added the no changelog This pull request does not need a changelog entry label Nov 13, 2024
panglesd added a commit to panglesd/odoc that referenced this pull request Nov 14, 2024
@panglesd panglesd removed the no changelog This pull request does not need a changelog entry label Nov 14, 2024
src/parser/test/test.ml Outdated Show resolved Hide resolved
src/model/semantics.ml Outdated Show resolved Hide resolved
Copy link
Collaborator

@gpetiot gpetiot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now!

Copy link
Collaborator

@Julow Julow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :) I particularly like that the frontmatter tags don't end up in the model.

@jonludlam
Copy link
Member

Thanks!

@jonludlam jonludlam merged commit 29d4908 into ocaml:master Nov 18, 2024
13 checks passed
jonludlam pushed a commit that referenced this pull request Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants