Upgrade to OCamlformat 0.27.0 #1227
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panglesd
reviewed
Oct 31, 2024
There was a problem hiding this comment.
Great to have a release of ocamlformat with support for 5.2!
Most of the changes are related to the parse-docstrings being true by default. Making two commits (one setting parse-docstrings=false and version=0.27.0 and the second one removing parse-docstrings=false) would make it easier to see what part of the code change.
I left some very minor comments, it looks good to me.
Julow
commented
Oct 31, 2024
Julow
force-pushed
the
preview-ocamlformat-0.27.0-preview1
branch
from
d87a81d to
faa2b77
Compare
Julow
force-pushed
the
preview-ocamlformat-0.27.0-preview1
branch
from
faa2b77 to
2a50637
Compare
Julow
changed the title
|
OCamlformat 0.27.0 as been released 🎉 This is ready to be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aim of this preview is to gather feedback.
Changelog can be found here: https://github.com/ocaml-ppx/ocamlformat/blob/main/CHANGES.md