Creates a dedicated rule to generate support files #1000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panglesd
reviewed
Sep 15, 2023
src/html_support_files/dune
Outdated
| @@ -2,7 +2,7 @@ | |||
| ; of the vendored projects. | |||
|
|
|||
| (rule | |||
| (alias runtest) | |||
| (alias html-support-files) | |||
There was a problem hiding this comment.
Can it be both run by both runtest and html-support-files (we want the tests in CI to detect an unpromoted html_support_files)?
There was a problem hiding this comment.
Nit-picking, but why so long? Since it is something we will actually type...
Suggested change
| (alias html-support-files) | |
| (alias support-files) |
There was a problem hiding this comment.
Dune's manual suggests using (aliases runtest support-files).
Julow
reviewed
Sep 15, 2023
panglesd
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, regenerating support files requires using the test rule, which feels weird because changing the css has very little to do with tests. It also allows to generate the support files without running the test more easily.