Fixup constraints #2760
Open
Fixup constraints #2760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Older versions like 0.1.1 exit fail with this error: ``` File "tool/ood-gen/lib/success_story.ml", line 13, characters 12-79: 13 | [@@deriving of_yaml, stable_record ~version:t ~add:[ slug; body_md; body_html ]] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Error: Ppxlib.Deriving: 'of_yaml' is not a supported type deriving generator ```
Previous versions fail with
```
File "tool/ood-gen/lib/academic_institution.ml", line 41, characters 53-79:
41 | str ^ "T00:00:00+00:00" |> Ptime.of_rfc3339 |> Ptime.rfc3339_string_error
^^^^^^^^^^^^^^^^^^^^^^^^^^
Error: Unbound value Ptime.rfc3339_string_error
```
The old version 0.10.6 fails with
```
File "src/ocamlorg_web/lib/ocamlorg_web.ml", line 12, characters 35-69:
12 | Mirage_crypto_rng_lwt.initialize (module Mirage_crypto_rng.Fortuna);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Error: This expression is packed module, but the expected type is unit
```
So this adds the dependency to the build files as well as to the OPAM
files.
Leonidas-from-XIV
force-pushed
the
fixup-constraints
branch
from
8d7d045
to
cb3fba3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While updating an older OPAM switch I realized that the versions that are installed are too old to successfully compile, so I had to add a few constraints on versions and add dependencies that were not declared before.