Backport re to OCaml 4.08 #589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgrinberg
approved these changes
Sep 19, 2025
Member
rgrinberg
left a comment
rgrinberg
left a comment
There was a problem hiding this comment.
I don't accepting so long as you take on the responsibility for maintaining 4.08 compat and sending patches to keep it working.
Member
Author
I'm happy to do that as long as opam depends on |
kit-ty-kate
force-pushed
the
ocaml-4.08-backport
branch
from
5581352 to
3e9e6b0
Compare
kit-ty-kate
force-pushed
the
ocaml-4.08-backport
branch
from
3e9e6b0 to
dba9513
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disclaimer: this is totally fine if this PR isn't merged.
I'm trying to upgrade to re 1.14.0 in opam itself and i was faced by the new lower-bound restriction on OCaml 4.13.
I needed to make a patch for us to be able to use it and i'm sharing it here in case anyone else faces the same issue.
I've split the commits in two as given the opam file expected OCaml >= 4.12 to work, i'm guessing dropping 4.12 wasn't intended.
The second commit backports to OCaml 4.08 with an implementation of atomics similar to the one added in OCaml 4.12: ocaml/ocaml@04d9c42
Feel free to take or drop any one of these commits