Introduce project-wide renaming #1431
Draft
+74
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a first functional version of project-wide renaming in ocaml-lsp based on preview work on Merlin.
It re-employs the existing mechanism to handle function labelled arguments correctly. There is no guarantees related to possible shadowing. Here is an example of the feature in action, renaming a value of a functor included from its parameter. The name is changes in all the files, both in signatures and implementations, and the project rebuilds immediately:
project-wide-renaming.mov
This PR is based on #1386 and only the last 2 commits are relevant.