fix(dune): enable dune rpc by default

Dune build --watch integration relies on dune RPC, but this was only enabled during tests. Enable Dune integration by default instead, as suggested by @rgrinberg. Fixes #690 Signed-off-by: Edwin Török <[email protected]> ps-id: 458AE51C-44DA-4CA6-B457-F0431E27FA3E
ocaml · Apr 22, 2022 · c7dc1ed · c7dc1ed
1 parent 86f0f7d
commit c7dc1ed
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/CHANGES.md b/CHANGES.md
@@ -1,3 +1,9 @@
+# 1.11.3
+
+## Fixes
+
+- Enable dune rpc integration by default (#691, fixes #690)
+
 # 1.11.2
 
 ## Fixes

diff --git a/ocaml-lsp-server/src/dune.ml b/ocaml-lsp-server/src/dune.ml
@@ -713,10 +713,10 @@ let create workspaces (client_capabilities : ClientCapabilities.t) diagnostics
 
 let create workspaces (client_capabilities : ClientCapabilities.t) diagnostics
     progress document_store ~log =
-  if inside_test then
+  if inside_test then ref Closed
+  else
     create workspaces client_capabilities diagnostics progress document_store
       ~log
-  else ref Closed
 
 let run_loop t =
   Fiber.repeat_while ~init:() ~f:(fun () ->