fix: replace existing version field in opam files during dune subst#14136
Open
robinbb wants to merge 1 commit intoocaml:mainfrom
Open
fix: replace existing version field in opam files during dune subst#14136robinbb wants to merge 1 commit intoocaml:mainfrom
robinbb wants to merge 1 commit intoocaml:mainfrom
Conversation
robinbb
force-pushed
the
robinbb-fix-subst-duplicate-version-878
branch
from
592d985 to
37828b6
Compare
…caml#878) When an opam file already contains a version: field, dune subst was prepending a new version: line instead of replacing the existing one, resulting in duplicate version fields. Fix by checking for an existing version: line and replacing it in place rather than always prepending. Signed-off-by: Robin Bate Boerop <me@robinbb.com>
robinbb
force-pushed
the
robinbb-fix-subst-duplicate-version-878
branch
from
37828b6 to
1a9c6f9
Compare
Member
|
Could you add a change log entry? |
rgrinberg
approved these changes
Apr 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #878.
When an opam file already contains a
version:field,dune substprepends a newversion:line instead of replacing the existing one. This results in duplicate version fields:The fix checks for an existing
version:line usingReand replaces it in place rather than always prepending.