[3.18] backport #11619 #11626
Merged
[3.18] backport #11619 #11626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l#11619) pkgconf uses the personality to locate the correct library when the library can be found with multiple toolchains. For instance, on Cygwin, pkgconf could detect libcurl (built with cygwin1.dll), libcurl (built with x86_64-w64-mingw32), or libcurl (built with i686-w64-mingw32). It needs the right `--personality` flag to select between these libraries, which we pass when asking for the `--cflags` or `--libs`. We also need it when validating the expression, or pkgconf returns an error: $ (cd _build/default && config/discover.exe) which: pkgconf -> found: C:\Users\Antonin\AppData\Local\opam\default-2\bin\pkgconf.exe run: C:\Users\Antonin\AppData\Local\opam\default-2\bin\pkgconf.exe --print-errors "libcurl >= 7.28.0" -> process exited with code 1 -> stdout: -> stderr: | Package libcurl was not found in the pkg-config search path. | Perhaps you should add the directory containing `libcurl.pc' | to the PKG_CONFIG_PATH environment variable | Package 'libcurl' not found Error: Package libcurl was not found in the pkg-config search path. Perhaps you should add the directory containing `libcurl.pc' to the PKG_CONFIG_PATH environment variable Package 'libcurl' not found Signed-off-by: Antonin Décimo <[email protected]>
Leonidas-from-XIV
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR backports the PR to correctly pass the flag to
pkg-conf.cc @MisterDA