chore: hardcode unix and threads library in bootstrap#11624
chore: hardcode unix and threads library in bootstrap#11624Alizter wants to merge 1 commit intoocaml:mainfrom
Conversation
Alizter
force-pushed
the
fix-bootstrap-promotion
branch
from
fb25cdf to
63e99b5
Compare
Signed-off-by: Ali Caglayan <alizter@gmail.com>
Alizter
force-pushed
the
fix-bootstrap-promotion
branch
from
63e99b5 to
b1e0eec
Compare
| ]) | ||
| |> Action_builder.of_memo | ||
| in | ||
| let externals = |
There was a problem hiding this comment.
I understand that Dune generates the thread.posix every time, but I don't understand where it comes from. What is a change in the compiler?
There was a problem hiding this comment.
I don't understand why this is reported like this. Maybe @nojb knows the reason?
There was a problem hiding this comment.
I believe we are using findlib (or dune's version) for finding these external libraries. At some point ~ OCaml 5.2 we started getting threads.posix rather than both unix and threads.
There was a problem hiding this comment.
It is a bug in 153fcd1, which inverted the condition. threads.posix is supposed to be filtered out.
There was a problem hiding this comment.
@nojb Good catch! I will open another PR with a fix.
|
Fix is here: #11636 |
3 participants
It was discussed that we should be doing something like this in #11199.