pkg: Display error message when no dependencies exist in dune-project
#11573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marek Kubica <[email protected]>
gridbugs
reviewed
Mar 27, 2025
gridbugs
reviewed
Mar 27, 2025
|
Can you add a test of the new behaviour. |
Signed-off-by: Marek Kubica <[email protected]>
maiste
reviewed
Apr 1, 2025
Signed-off-by: Marek Kubica <[email protected]>
maiste
approved these changes
Apr 2, 2025
gridbugs
approved these changes
Apr 3, 2025
36 tasks
|
There is something really wrong that it displays the warning 4 times (which at least points to the fact that we're doing 4x as much work as we should), I'm investigating this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow-up/replacement of #11555 this PR displays an warning if the package to be locked is declared in
dune-projectbut has no dependencies.I could imagine an additional step of reading the OPAM file and actually erroring out if it has dependencies declared there. That sounds like something we don't want to support. WDYT?