Retrieve all dependencies of a package #166
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pends. Du to the cost of retrieving all packages graph dependencies, a choice is done on dependencies retrieving. If dependencies cache exists, uses it, otherwise calculate using opam file dependencies.
|
irrelevant as statistics are no more computed (see #221 ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For most popular calculation, we use the leaf packages stats, and for that we retrieve dependencies and remove them in a window of 2 minutes (cf. c79bcc7). We used opam file depends to retrieve dependencies, instead of computing the all dependencies. That's how it is done in this PR.
As calculating it for all package is time consuming (takes 1h for all opam-repo), a cache is required, that can be generated using
--generate-dcacheoption.In case the cache is non existent, it is the old behavior that is used.