Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable Gc.compact in Gc tests #508

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Reenable Gc.compact in Gc tests #508

wants to merge 1 commit into from

Conversation

jmid
Copy link
Collaborator

@jmid jmid commented Jan 9, 2025

This one-line PR is a left-over from #469. It was omitted from that one to move forward with the Gc tests.

I expect the PR to trigger the two outstanding Gc issues:

To avoid introducing noise in CI runs, it should be merged once these two have been resolved.

@jmid
Copy link
Collaborator Author

jmid commented Jan 9, 2025

CI summary:

These were as expected.

Out of 33 workflows 3 failed with genuine issues.

@jmid jmid force-pushed the gc-test-enable-compact branch from 0a6b2ed to c592e05 Compare February 4, 2025 14:15
@jmid
Copy link
Collaborator Author

jmid commented Feb 4, 2025

Dummy push to trigger a fresh CI rerun with the fix of ocaml/ocaml#13090 merged

@jmid
Copy link
Collaborator Author

jmid commented Feb 4, 2025

CI summary for c592e05

The latter is expected as #470 has now been fixed on trunk but will continue to trigger on 5.3.

Out of 34 workflows, 1 failed with a genuine error and 2 with false alarms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant