Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change error to warning for redundant patterns #222

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Change error to warning for redundant patterns #222

wants to merge 2 commits into from

Conversation

paulpatault
Copy link
Contributor

No description provided.

@paulpatault paulpatault force-pushed the redundant-warns branch 2 times, most recently from 21a7862 to 640dae0 Compare June 5, 2022 14:23
@paulpatault paulpatault marked this pull request as ready for review June 5, 2022 14:26
@paulpatault paulpatault changed the title Change error to warning for redondant patterns Change error to warning for redundant patterns Jun 7, 2022
@pascutto
Copy link
Contributor

pascutto commented Jun 8, 2022

Thanks!
I'm not sure it is a good idea that the gospel library prints error messages at all, I would argue for something that lets its user decide how to handle the case where an error/warning happens, otherwise it becomes hard to detect these from the client code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulpatault @pascutto