Add bounds checks to the frame table emission code #3987
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gretay-js
reviewed
May 12, 2025
gretay-js
reviewed
May 14, 2025
gretay-js
approved these changes
May 14, 2025
Gbury
pushed a commit
to Gbury/flambda-backend
that referenced
this pull request
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation of re-enabling #3931, this PR adds bounds checks to the emission code for frame tables. Due to recent compiler changes, some integers that used to be non-negative (the live offsets in the frame table) can now be negative. The changes in this PR make it clear which ranges are expected for various constants in the frame table emission code.
Notably, I have left
efa_wordalone for now. I believe it is a signed integer of target-platform width, but I wasn't completely sure.