Modality.Value.Const should behave like a product
#3961
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riaqn
force-pushed
the
refactor-modality-const-repr
branch
from
2f81160 to
f37af34
Compare
dkalinichenko-js
force-pushed
the
refactor-modality-const-repr
branch
from
f37af34 to
f852f50
Compare
dkalinichenko-js
force-pushed
the
clean-up-mode-axis-gadt
branch
from
9f251f0 to
7260beb
Compare
dkalinichenko-js
force-pushed
the
refactor-modality-const-repr
branch
from
f852f50 to
aa8de35
Compare
|
Thank you @d-kalinichenko ! I reviewed your fixes and they look great! |
dkalinichenko-js
approved these changes
May 21, 2025
riaqn
force-pushed
the
refactor-modality-const-repr
branch
from
57a5d4b to
bf120a4
Compare
Gbury
pushed a commit
to Gbury/flambda-backend
that referenced
this pull request
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #3949
This PR refactors the interface of
Modality.Value.Constto make it behave like a product of axes (that you can project and update specific axis) instead of a sequence of atoms (that you compose).This allows other incoming PRs that do the following:
@no_mutable_implied_modalities#3962portablewithportable)Review
@dkalinichenko-js , could you look at the changes in
typemode.mland tests. In particular, could you check that the implication and the print back is still as expected. Feel free to add more tests.