Document implications #3944
Merged
Document implications #3944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks about right. I'd add a motivating example for modalities: if |
|
Good idea. Please review my little addition. |
|
Perfect. This PR is then waiting for #3943 to merge. |
|
Just reminding ourselves that this exists. |
goldfirere
force-pushed
the
rae/modes-syntax-docs
branch
from
430e906 to
954c630
Compare
goldfirere
force-pushed
the
rae/implications
branch
from
af2d40b to
0986354
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As tin.
Note that this targets #3943, not
main, so it may make sense to merge #3943 before this.Review: @dkalinichenko-js