Add testing infrastructure for reviewing code gen and the compiled DFA#174
Open
hhugo wants to merge 5 commits intoocaml-community:masterfrom
Open
Add testing infrastructure for reviewing code gen and the compiled DFA#174hhugo wants to merge 5 commits intoocaml-community:masterfrom
hhugo wants to merge 5 commits intoocaml-community:masterfrom
Conversation
Contributor
Author
toots
approved these changes
Feb 10, 2026
Member
toots
left a comment
toots
left a comment
There was a problem hiding this comment.
This makes sense to me, you're reorganizing the code and adding tests to solidify the current outputs.
Contributor
Author
|
@pmetzger, would you have time to look at this ? |
Contributor
Author
|
@alainfrisch, @pmetzger. @Drup, any bandwidth to review this ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal is to prepare for future contributions. It can be helpful to review the effect of a change in term of change to generated code and DFA.
I plan to rely on this to implement #5