Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a GitHub Actions CI pipeline #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add a GitHub Actions CI pipeline #4

wants to merge 1 commit into from

Conversation

MisterDA
Copy link
Collaborator

@MisterDA MisterDA commented Mar 21, 2025

Network is currently failing?
Close #7.

@Alizter
Copy link
Collaborator

Alizter commented Mar 21, 2025

Let's disable the windows build for now, since we expect it to fail. We can reenable it when we add windows support.

@Alizter
Copy link
Collaborator

Alizter commented Mar 21, 2025

Lwt is an optional dependency which means notty.lwt won't even build so examples/ won't find it.

@Alizter
Copy link
Collaborator

Alizter commented Mar 21, 2025

We should mark lwt as a test dependency in dune-project like (lwt :with-test).


- run: opam install . --deps-only --with-test

- run: opam exec -- dune build
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This relies on the @default alias which is by default @all. We don't want to build everything in benchmarks/ for instance. To do this have a look at https://dune.readthedocs.io/en/stable/reference/aliases/default.html

We should probably just build src, src-unix and src-lwt for @default.

That is however orthogonal to what we want to do here. We are probably only interested in doing dune build @install which builds an install layout. Afterwards we do dune runtest which is just dune build @runtest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

set up continuous integration
2 participants