Skip to content

Conversation

@mihawk90
Copy link
Contributor

@mihawk90 mihawk90 commented Oct 6, 2025

Description

#9442 efca325 already increased the default bitrate for various encoders. However, some were missed and this PR fills the gap:

  • Mac-VT
  • OpenH264
  • Texture AMF
  • VAAPI

Note I wasn't sure about the Texture AMF one because there's 4 occurrences (2 for AVC, 2 for HEVC). But I think one each is for new setups and one for migrating existing setups?

There's also one more in nvenc-compat, but the comment made me think this is not used for new setups anymore and just used for legacy configs that were never upgraded? Let me know if it should still be adjusted.

static void nvenc_defaults_base(enum codec_type codec, obs_data_t *settings)
{
/* Defaults from legacy FFmpeg encoder */
obs_data_set_default_int(settings, "bitrate", 2500);

Motivation and Context

Noticed in unrelated testing that VAAPI was still defaulting to 2500, fixed it and found other occurrences of the same.

How Has This Been Tested?

Checked VAAPI and OpenH264, both defaulted to 6000.
Can't test Mac-VT and Tex-AMF.

Types of changes

  • Tweak (non-breaking change to improve existing functionality)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

efca325 already increased the default bitrate for various encoders.
However, some were missed and this commit fills the gap:

* Mac-VT
* OpenH264
* Texture AMF
* VAAPI
@PatTheMav PatTheMav moved this to Ready For Merge in OBS Studio 32.1 PR Considerations Oct 8, 2025
@WizardCM WizardCM added the Enhancement Improvement to existing functionality label Oct 16, 2025
Copy link
Member

@RytoEX RytoEX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

@RytoEX RytoEX self-assigned this Nov 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement Improvement to existing functionality

Projects

Status: Ready For Merge

Development

Successfully merging this pull request may close these issues.

5 participants