Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend: Enforce Qt to have a DE-agnostic behavior on Linux #11815

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tytan652
Copy link
Collaborator

@tytan652 tytan652 commented Feb 1, 2025

Description

Enforce Qt to have a DE-agnostic behavior on Linux

I didn't have Plasma screenshot since I have no machine under it.

Before (with Qt 6.8 on GNOME):

Screenshot From 2025-02-01 16-58-58

After:

Screenshot From 2025-02-01 16-59-12

Motivation and Context

If the platform theme is not enforced, Plasma Wayland will enforce SSD decoration (that also lead to some menu issues depending on the distro defaults). This also has made some users think that we explicitly support SSD which is not the case, we rely on Qt default CSD.

If the wayland decoration is not enforced, under GNOME, Qt (since 6.8) will try to enforce a GNOME-like decoration. DO NOT mix it up with GNOME X11 SSD decoration.

There is also third-party Qt plugins (e.g. qt5ct, qgnome) that caused their share of issues in the past, removing them from the list of potential culprit still can be useful.

I think this is not controversial to expect OBS Studio to look the same under any desktop environment.

How Has This Been Tested?

Ran locally OBS (outside of a Flatpak) and no issue were met using file chooser (use portals now rather the GTK 3 dialog) and the window decoration is Bradient.

Types of changes

  • Tweak (non-breaking change to improve existing functionality)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@tytan652 tytan652 added Enhancement Improvement to existing functionality Linux Affects Linux labels Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improvement to existing functionality Linux Affects Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant