nv-filters: Updates for new SDK #11814
Open
+3
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkviet
added
Seeking Testers
This updates checks against current SDK redist versions: - 0.7.6 (Video Effects); - 1.6.1.2 (Audio Effects). Users will receive a warning if their redist versions is smaller than these. Signed-off-by: pkv <[email protected]>
We don't use any more cuda RT functions. So this commit removes their loading from the cudaRT dll. This fixes also a crash when loading different versions of cudaRT when the SDK is updated [1]. [1] obsproject#11813 Signed-off-by: pkv <[email protected]>
pkviet
force-pushed
the
nvvfx_load_fix
branch
from
edbdb05 to
e33c7f4
Compare
pkviet
added
the
Code Cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR does two things:
updates the checks against the new redistributables of NVIDIA AUDIO & VIDEO effects to:
cleans up the code related with cuda RT functions, which is not used anymore.
Motivation and Context
Allow nv-filters to work with newer SDK.
This also fixes bug: #11813
How Has This Been Tested?
The video & audio effects load fine on windows 11 PRO 24H2.
Types of changes
Checklist: