Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpm: Fix potential null-pointer dereference #11805

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

bpm: Fix potential null-pointer dereference #11805

wants to merge 1 commit into from

Conversation

lexano-ivs
Copy link
Contributor

Description

update_metrics() in bpm.c is checking for null pointer arguments, and there was a very minor chance of de-referencing a null-pointer in the logged message. Correct the logic to prevent this from happening.

How Has This Been Tested?

Tested with a local build with live streams to Twitch with Enhanced Broadcasting.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

RytoEX
RytoEX requested changes Jan 31, 2025
View reviewed changes
Copy link
Member

@RytoEX RytoEX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The correct prefix is bpm: (lowercase).

Wrap the commit message body at 72 characters.

@lexano-ivs
bpm: Fix potential null-pointer dereference
aced1d9 
`update_metrics()` in `bpm.c` is checking for null pointer arguments,
and there was a very minor chance of dereferencing a null-pointer in
the logged message. Correct the logic to prevent this from happening.
@lexano-ivs
Copy link
Contributor Author

The correct prefix is bpm: (lowercase).

Wrap the commit message body at 72 characters.

Done.

@RytoEX RytoEX changed the title BPM: Fix potential null-pointer dereference bpm: Fix potential null-pointer dereference Jan 31, 2025
@WizardCM WizardCM added the Bug Fix Non-breaking change which fixes an issue label Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RytoEX RytoEX RytoEX requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Bug Fix Non-breaking change which fixes an issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lexano-ivs @RytoEX @WizardCM