Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: Turn off camera reaction by default on macOS 14.4 and later #11652

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gxalpha
Copy link
Member

@gxalpha gxalpha commented Dec 20, 2024

Description

Adds an Info.plist flag available since macOS 14.4 that turns off the reaction effects by default (which Apple turned on by default for all apps for some reason).
Amazingly, this is only documented in @discussion part the AVCaptureDevice.h header in the macOS SDK (line 2335ff on the 15.2 SDK), not in the same part of the official documentation. (See also FB16132155)

In fact, I only know that it is even possible to disable it because I saw Zoom do it (the macOS UI very much encourages the user to turn it on, see the screenshot below) and then went digging as to how it was done.

Motivation and Context

The reaction effects that macOS adds by default are confusing to users as they're turned on by default and users don't know where they come from or where to turn them off. Setting this flag in the apps Info.plist prevents them from being turned on by default. The macOS UI makes it very obvious to the user where they can turn them on should they wish to do so.

This comes up often enough in support that I would consider it to be a bug fix.

How Has This Been Tested?

Changed the bundle identifier of OBS (which the reaction setting appears to be tied to).
After adding a camera source on first launch, got this notification:

Bildschirmfoto 2024-12-20 um 20 40 31

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Tweak (non-breaking change to improve existing functionality)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

The reaction effects that macOS adds by default are confusing to users
as they're turned on by default and users don't know where they come
from or where to turn them off. Setting this flag in the apps Info.plist
prevents them from being turned on by default. The macOS UI makes it
very obvious to the user where they can turn them on should they wish to
do so.
@gxalpha gxalpha added Bug Fix Non-breaking change which fixes an issue Enhancement Improvement to existing functionality labels Dec 20, 2024
@gxalpha gxalpha requested a review from PatTheMav December 20, 2024 20:05
@RytoEX
Copy link
Member

RytoEX commented Dec 20, 2024

Is this supplementary to #10901 ?

@gxalpha
Copy link
Member Author

gxalpha commented Dec 20, 2024

I wasn't actively aware of #10901, but looking at a glance I think it's a replacement; in my opinion we shouldn't try to nuke reactions completely (and also it appears it doesn't work?).
Also I thought I read somewhere that the key that's used there doesn't work on macOS (to be clear, this somewhere was somewhere different from Pat's comment #10901 (comment), but I can't remember where).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Fix Non-breaking change which fixes an issue Enhancement Improvement to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants