Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Move media control dynamic properties to ui file #11615

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cg2121
Copy link
Contributor

@cg2121 cg2121 commented Dec 10, 2024

Description

This moves the dynamic properties for the media control buttons from the cpp file to the ui file.

Motivation and Context

Nicer code

How Has This Been Tested?

Opened OBS and made sure media buttons still looked correct

Types of changes

  • Code cleanup (non-breaking change which makes code smaller or more readable)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

This moves the dynamic properties for the media control buttons
from the cpp file to the ui file.
@cg2121 cg2121 added Code Cleanup Non-breaking change which makes code smaller or more readable UI/UX Anything to do with changes or additions to UI/UX elements. labels Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Cleanup Non-breaking change which makes code smaller or more readable UI/UX Anything to do with changes or additions to UI/UX elements.
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants