libobs: Fix race when disconnecting raw video callbacks #11605
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ensures
raw_active
counter is only incremented/decremented if a callback was actually added/removed.Motivation and Context
Fixes #11329
There is a race condition here where the encoder stopping due to failure will call
remove_connection()
fromfull_stop()
and the output itself stopping will also call it fromend_data_capture_thread()
. This can result in theraw_active
counter being decremented twice to-1
, so that the next time an output is started the counter will be incremented to0
(instead of1
), which is treated as inactive.How Has This Been Tested?
Locally.
Types of changes
Checklist: