Improve DLL loading behavior on Windows #11569
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improves how we load various DLLs by preferring system32 DLLs, removing global
SetDllDirectory
changes, enabling safe path search mode and reducing risk of loading potentially wrong DLLs from the current directory.Motivation and Context
Annoyed by various bug reports that suggest OBS is vulnerable to DLL planting attacks. While this PR doesn't aim to solve that issue directly, it implements best practices to help reduce the risk. We still rely on the current directory for relative path generation which isn't ideal, but that's for another PR.
How Has This Been Tested?
Tested loading OBS with default set of plugins. More testing with 3rd party plugins with complex dependency chains might be needed, though
LOAD_LIBRARY_SEARCH_DLL_LOAD_DIR
should match the old behavior.Types of changes
Checklist: