Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

game-capture: reset hook_stop signal #11568

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

FanZR123
Copy link

@FanZR123 FanZR123 commented Nov 28, 2024

Description

If the game process is hooked successfully, but the game process does not call rendering. The capture_should_stop->capture_stopped of graphics-hook.dll will not be called.
The game plugin will fall into a loop:
1732765128

Motivation and Context

How Has This Been Tested?

  • Add a game capture source
  • Capture an application that does not render
  • Switch to another mode to stop capturing the application
  • Recapture the application

Types of changes

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@WizardCM WizardCM added Bug Fix Non-breaking change which fixes an issue Windows Affects Windows labels Nov 30, 2024
@WizardCM
Copy link
Member

Could you provide more exact reproduction steps of the issue? Maybe an name of a game you experienced this with?

@FanZR123
Copy link
Author

FanZR123 commented Dec 3, 2024

Could you provide more exact reproduction steps of the issue? Maybe an name of a game you experienced this with?

You can use Zoom to test

  1. Start a new meeting in Zoom
  2. Add the game source in OBS and capture Zoom
  3. End the meeting in Zoom

In addition, this problem has been encountered in Warframe and Sacred2, but it is very difficult to reproduce.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Fix Non-breaking change which fixes an issue Windows Affects Windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants