Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Remove hardcoded list widget spacing #11557

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cg2121
Copy link
Contributor

@cg2121 cg2121 commented Nov 23, 2024

Description

Not all list widgets were using this consistently, and these should be set in the themes instead.

Motivation and Context

Makes things consistent

How Has This Been Tested?

Looked at each list widget to make sure there was no extra spacing besides margins set in themes.

Types of changes

  • Tweak (non-breaking change to improve existing functionality)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@cg2121 cg2121 requested a review from Warchamp7 November 23, 2024 22:31
@cg2121 cg2121 added UI/UX Anything to do with changes or additions to UI/UX elements. Enhancement Improvement to existing functionality labels Nov 23, 2024
@Warchamp7
Copy link
Member

Default values can vary by operating system, so I'm a bit hesitant to remove hardcoded values. I'd rather ensure they're consistent everywhere.

In some places it's also difficult to replicate spacing behaviour using only QSS since the only real method is margin, and Qt has a lack of or inconsistent implementation of things like first-child / last-child.

This makes all list widget spacing set to 1.
@cg2121
Copy link
Contributor Author

cg2121 commented Dec 3, 2024

Updated to set the list widget spacing to 1 for all list widgets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improvement to existing functionality UI/UX Anything to do with changes or additions to UI/UX elements.
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants