Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rtmp-services: Change the server URL of AfreecaTV to SOOP Korea #11550

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Taeski-SOOP
Copy link

※ I'm requesting a new one because the commit arrangement is complicated. (Previous Request #11428)

Description

Effective October 15th, our service has been rebranded from Afreecatv to SOOP Korea.
We are planning to change the server URL of AfreecaTV to SOOP Korea.

Motivation and Context

We aim to adapt the current Afreecatv configurations to be compatible with SOOP.

How Has This Been Tested?

Locally tested and is working properly.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@norihiro
Copy link
Contributor

In the commit message,

  1. Remove a space between rtmp-services and :.
  2. The description line should be folded so that one line contains at most 72 characters.

To revise the commit message, use git commit --amend to edit the message. Then, use git push -f to force-push to GitHub.

Request a code modification due to the change of AfreecaTV name
@Taeski-SOOP Taeski-SOOP force-pushed the feature/taeski-soop-obs branch from 143ed45 to 7f2dd23 Compare November 25, 2024 02:58
@Taeski-SOOP Taeski-SOOP changed the title rtmp-services : Change the server URL of AfreecaTV to SOOP Korea rtmp-services: Change the server URL of AfreecaTV to SOOP Korea Nov 25, 2024
@Taeski-SOOP
Copy link
Author

@norihiro I revised it and force-push. Thank you for the guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants