-
-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OpenH264 support to obs-ffmpeg #10135
Open
Conan-Kudo
wants to merge
1
commit into
obsproject:master
Choose a base branch
from
Conan-Kudo:obs-ffmpeg-openh264-part1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
tytan652
suggested changes
Jan 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
x264 will never support another codec so the suffix .H264
is not useful.
Conan-Kudo
force-pushed
the
obs-ffmpeg-openh264-part1
branch
2 times, most recently
from
January 24, 2024 12:44
34fe17c
to
4bfc493
Compare
@tytan652 Adjusted. |
Conan-Kudo
force-pushed
the
obs-ffmpeg-openh264-part1
branch
from
January 24, 2024 13:12
4bfc493
to
a29a323
Compare
Conan-Kudo
force-pushed
the
obs-ffmpeg-openh264-part1
branch
from
January 25, 2024 09:53
a29a323
to
e2c3337
Compare
Conan-Kudo
force-pushed
the
obs-ffmpeg-openh264-part1
branch
from
April 2, 2024 02:09
e2c3337
to
4be4bbb
Compare
Conan-Kudo
force-pushed
the
obs-ffmpeg-openh264-part1
branch
from
July 31, 2024 23:18
4be4bbb
to
8e1489f
Compare
Conan-Kudo
force-pushed
the
obs-ffmpeg-openh264-part1
branch
5 times, most recently
from
October 5, 2024 21:35
dc97c80
to
4324042
Compare
tytan652
reviewed
Oct 5, 2024
This allows users to leverage the OpenH264 codec from Cisco to encode H.264 video content. It is significantly reduced in capability from alternatives, but it does the job. This also provides a framework for adding support for other H.264 software codecs provided through FFmpeg.
Conan-Kudo
force-pushed
the
obs-ffmpeg-openh264-part1
branch
from
January 21, 2025 16:37
4324042
to
f546912
Compare
Conan-Kudo
changed the title
Refactor and add OpenH264 support to obs-ffmpeg
Add OpenH264 support to obs-ffmpeg
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is split out of #8529 to provide only the commit that adds the wiring for the codec.
This also provides a framework for adding support for other H.264 software codecs provided through FFmpeg.
Motivation and Context
A number of distributions use OpenH264 distributed by Cisco to provide a fully licensed H.264 implementation (in particular, both Fedora Linux and openSUSE Linux do). However, OBS Studio cannot currently use it.
This change allows OBS Studio to use OpenH264 through FFmpeg if it's available.
How Has This Been Tested?
This was tested on Fedora Linux 38-40 with ffmpeg 6.0-6.1 and CentOS Stream 9 with ffmpeg 5.1.4 on x86_64 and AArch64.
Types of changes
Checklist: