Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenH264 support to obs-ffmpeg #10135

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Conan-Kudo
Copy link
Contributor

@Conan-Kudo Conan-Kudo commented Jan 24, 2024

Description

This is split out of #8529 to provide only the commit that adds the wiring for the codec.

This also provides a framework for adding support for other H.264 software codecs provided through FFmpeg.

Motivation and Context

A number of distributions use OpenH264 distributed by Cisco to provide a fully licensed H.264 implementation (in particular, both Fedora Linux and openSUSE Linux do). However, OBS Studio cannot currently use it.

This change allows OBS Studio to use OpenH264 through FFmpeg if it's available.

How Has This Been Tested?

This was tested on Fedora Linux 38-40 with ffmpeg 6.0-6.1 and CentOS Stream 9 with ffmpeg 5.1.4 on x86_64 and AArch64.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

Copy link
Collaborator

@tytan652 tytan652 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

x264 will never support another codec so the suffix .H264 is not useful.

UI/data/locale/en-US.ini Outdated Show resolved Hide resolved
UI/data/locale/en-US.ini Outdated Show resolved Hide resolved
UI/window-basic-auto-config-test.cpp Outdated Show resolved Hide resolved
UI/window-basic-settings-stream.cpp Outdated Show resolved Hide resolved
UI/window-basic-settings.cpp Outdated Show resolved Hide resolved
@Conan-Kudo Conan-Kudo force-pushed the obs-ffmpeg-openh264-part1 branch 2 times, most recently from 34fe17c to 4bfc493 Compare January 24, 2024 12:44
@Conan-Kudo
Copy link
Contributor Author

@tytan652 Adjusted.

@Conan-Kudo Conan-Kudo force-pushed the obs-ffmpeg-openh264-part1 branch from 4bfc493 to a29a323 Compare January 24, 2024 13:12
@Conan-Kudo Conan-Kudo requested a review from tytan652 January 24, 2024 13:25
@Conan-Kudo Conan-Kudo force-pushed the obs-ffmpeg-openh264-part1 branch from a29a323 to e2c3337 Compare January 25, 2024 09:53
@Conan-Kudo Conan-Kudo force-pushed the obs-ffmpeg-openh264-part1 branch from e2c3337 to 4be4bbb Compare April 2, 2024 02:09
@Conan-Kudo Conan-Kudo force-pushed the obs-ffmpeg-openh264-part1 branch from 4be4bbb to 8e1489f Compare July 31, 2024 23:18
@Conan-Kudo Conan-Kudo force-pushed the obs-ffmpeg-openh264-part1 branch 5 times, most recently from dc97c80 to 4324042 Compare October 5, 2024 21:35
UI/data/locale/en-US.ini Outdated Show resolved Hide resolved
This allows users to leverage the OpenH264 codec from Cisco to encode
H.264 video content. It is significantly reduced in capability from
alternatives, but it does the job.

This also provides a framework for adding support for other H.264
software codecs provided through FFmpeg.
@Conan-Kudo Conan-Kudo force-pushed the obs-ffmpeg-openh264-part1 branch from 4324042 to f546912 Compare January 21, 2025 16:37
@Conan-Kudo Conan-Kudo changed the title Refactor and add OpenH264 support to obs-ffmpeg Add OpenH264 support to obs-ffmpeg Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Feature New feature or plugin
Projects
Status: Backlog
Development

Successfully merging this pull request may close these issues.

4 participants