Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Update softprops/action-gh-release to v2.0.4 #118

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

RytoEX
Copy link
Member

@RytoEX RytoEX commented Apr 10, 2024

Description

The softprops/action-gh-release action is the last remaining action in this repo that was still using node16. Updating should remove the associated warnings.

Motivation and Context

Want less CI warnings so the meaningful warnings stand out.

How Has This Been Tested?

It hasn't. I'm not sure how to test it, but I think @PatTheMav has done it in the past?

Types of changes

  • Tweak (non-breaking change to improve existing functionality)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

This is the last remaining action in this repo that was still using
node16. Updating should remove the associated warnings.
@RytoEX RytoEX added the enhancement New feature or request label Apr 10, 2024
@RytoEX RytoEX requested a review from PatTheMav April 10, 2024 23:24
@RytoEX RytoEX self-assigned this Apr 10, 2024
@PatTheMav
Copy link
Member

To test the action, just tag a release on your fork (after pushing the change to master) and check if it's created successfully.

After that, force-push the upstream master commit again to "undo" the changes (also force-push tags to remove the new tag as well).

@RytoEX
Copy link
Member Author

RytoEX commented Apr 10, 2024

To test the action, just tag a release on your fork (after pushing the change to master) and check if it's created successfully.

After that, force-push the upstream master commit again to "undo" the changes (also force-push tags to remove the new tag as well).

Thanks. Will try that.

@RytoEX
Copy link
Member Author

RytoEX commented Apr 11, 2024

Tested on my fork and got CI to be green with no warnings about node16.

During this, we discovered that if the repo does not have notarization/codesigning properly set up, macOS packaging will fail:

Prepare all required actions
Error: The template is not valid. RytoEX/obs-plugintemplate/.github/workflows/build-project.yaml@7c74a20ff2e9f491a0e74e27c9dd9ea6ac3b0d6f (Line: 147, Col: 21): Error reading JToken from JsonReader. Path '', line 0, position 0.

Line 147 is:

          notarize: ${{ fromJSON(needs.check-event.outputs.notarize) && fromJSON(steps.codesign.outputs.haveNotarizationUser) }}

After some off-thread discussion with @PatTheMav , we determined that haveNotarizationUser is an empty string, which seems to break fromJSON.

##[debug]......Evaluating String:
##[debug]......=> 'haveNotarizationUser'
##[debug]....=> ''
##[debug]RytoEX/obs-plugintemplate/.github/workflows/build-project.yaml@7c74a20ff2e9f491a0e74e27c9dd9ea6ac3b0d6f (Line: 147, Col: 21):

This is out-of-scope for this PR, but I wanted to document for posterity. It's something that we should address at some point.

@RytoEX RytoEX merged commit c314e60 into obsproject:master Apr 12, 2024
6 checks passed
@RytoEX RytoEX deleted the update-actions branch April 12, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants