Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows: Ignore duplicate adapter names #169

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

prgmitchell
Copy link
Member

Description

Prevent the "Wrong GPU" message when both adapters are the same.

Motivation and Context

Saw this log was triggering the error message:
https://obsproject.com/logs/BaZPLgfCwGAtNWc9

How Has This Been Tested?

Tested the log above to confirm it is resolved along with a few logs where the message should still show up like this one:
https://obsproject.com/logs/StrpkEaUZ2OzKHqQ

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

Prevent the "Wrong GPU" message when both adapters are the same.
@RytoEX
Copy link
Member

RytoEX commented Nov 22, 2024

I am pretty sure I've seen this happen with any kind of GPU, such as dGPUs, and I've seen the same GPU logged 3 times instead of just 2. This might be good enough to mitigate the majority of cases, and maybe we just need to merge this and wait for others to pop up so we can adjust as needed.

@prgmitchell
Copy link
Member Author

I am pretty sure I've seen this happen with any kind of GPU, such as dGPUs, and I've seen the same GPU logged 3 times instead of just 2. This might be good enough to mitigate the majority of cases, and maybe we just need to merge this and wait for others to pop up so we can adjust as needed.

I thought I had seen it in other circumstances too but this was the one I was able to find an example of. I agree that this is the one that popped up when searching "Wrong GPU" messages in Discord but we should still be on the lookout for other situations where this needs to be fixed for a future PR.

Copy link
Member

@Fenrirthviti Fenrirthviti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me that this shouldn't have a major impact on later fixes if they're required, and should result in cleaner analysis in the short term for most cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants