-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
encoding: Fix low bitrate check #157
base: master
Are you sure you want to change the base?
Conversation
Do you have logs to test this against? |
8ef3ffb
to
19584b5
Compare
here's for : Those are the encoders I have easy access to right now, if you want more I can find, but it'll take a bit more time. |
19584b5
to
d6a55de
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look fine to me conceptually. No reason to have a specific check per-encoder for this. The intent might have been at some point to expand this check to do other things, but we're probably well past that.
The fallback qsv log causes an error with this PR:
|
d6a55de
to
0b66e00
Compare
fixed the regex, and added a try except so that, if another unforeseen issue happens with the regexp it fails the check gracefully instead of stopping the whole analysis. |
checks/encoding.py
Outdated
@@ -3,6 +3,9 @@ | |||
import re | |||
|
|||
|
|||
params_re = re.compile(r"\t(?P<key>\w+):?\s*(?P<value>\S+)") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any known case where the colon is missing/optional? :?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
currently, none that I can see, was an attempt to possibly catch future changes in formatting, but I agree it's probably a bit too greedy.
would you rather I remove the ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can make it non-optional.
0b66e00
to
b7c327f
Compare
Description
This fixes the "Low Stream Bitrate" check to work with the new encoder names, and reworks it to work with all of obs' default encoders, and be less disruptible.
Motivation and Context
The "Low Stream Bitrate" check is currently nonfunctional, due to the encoders rename in OBS 28.
How Has This Been Tested?
This was tested by manually feeding the lines to the function and checking it gets the right values.
It was tested with
Types of changes
Checklist: