Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin: Datepicker #3794

Merged
merged 1 commit into from
Jul 5, 2024
Merged

Add plugin: Datepicker #3794

merged 1 commit into from
Jul 5, 2024

Conversation

joycode-hub
Copy link
Contributor

I am submitting a new Community Plugin

Repo URL

Link to my plugin: https://github.com/joycode-hub/datepicker-plugin.git

Release Checklist

  • I have tested the plugin on
    • Windows
    • macOS
    • Linux
    • Android (if applicable)
    • iOS (if applicable)
  • My GitHub release contains all required files
    • main.js
    • manifest.json
    • styles.css (optional)
  • GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
  • The id in my manifest.json matches the id in the community-plugins.json file.
  • My README.md describes the plugin's purpose and provides clear usage instructions.
  • I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.
  • I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
  • I have added a license in the LICENSE file.
  • My project respects and is compatible with the original license of any code from other plugins that I'm using.
    I have given proper attribution to these other projects in my README.md.

@github-actions github-actions bot changed the title Add Datepicker plugin Add plugin: Datepicker Jun 29, 2024
@ObsidianReviewBot
Copy link
Collaborator

ObsidianReviewBot commented Jun 30, 2024

Thank you for your submission, an automated scan of your plugin code's revealed the following issues:

Required

(Skipped)


Do NOT open a new PR for re-validation.
Once you have pushed all of the required changes to your repo, the bot will update the labels on this PR within 6 hours.
If you think some of the required changes are incorrect, please comment with /skip and the reason why you think the results are incorrect.

@ObsidianReviewBot ObsidianReviewBot self-assigned this Jun 30, 2024
@ObsidianReviewBot ObsidianReviewBot added Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made and removed Ready for review labels Jun 30, 2024
@joycode-hub
Copy link
Contributor Author

/skip All uses of style are purely functional and have nothing to do with thematic purposes, ie: setting the size and location of a popup modal according to input element size and cursor position, preventing default behavior of darkened background opacity on plugin modal popup as it conflicts with the intended purpose of the plugin (this happens only for my plugin and does not affect behavior for anything else).

@github-actions github-actions bot added the Skipped code scan Code scanning skipped because submission is not in TS/author believes result is wrong label Jun 30, 2024
@ObsidianReviewBot ObsidianReviewBot added Ready for review and removed Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made labels Jul 2, 2024
@ObsidianReviewBot ObsidianReviewBot removed their assignment Jul 2, 2024
@ObsidianReviewBot
Copy link
Collaborator

Changes requested by bot have been made, assigning human for additional review.

@joethei
Copy link
Collaborator

joethei commented Jul 3, 2024

let app: App;
You should not use global variables whenever possible, read here why: http://wiki.c2.com/?GlobalVariablesAreBad

app = this.app;
And specifically don't keep a global reference to the app object.

onunload() {
Instead of copy pasting this code use:
this.registerDomEvent(activeDocument, 'keyup', (event) => ...)

Also, your code won't work in popup windows.
See here how to update your plugin to support pop out windows:
https://obsidian.md/blog/how-to-update-plugins-to-support-pop-out-windows/

modalEl.style.position = 'fixed';, modalEl.style.maxHeight = '30px';
This should be moved to CSS.

@joethei joethei added Changes requested Minor changes requested PR can be merged after some final changes have been requested and removed Ready for review Skipped code scan Code scanning skipped because submission is not in TS/author believes result is wrong labels Jul 3, 2024
@joycode-hub
Copy link
Contributor Author

Hello,
I have updated my code which now takes into account all of your suggestions in tag 0.2.0,
Please let me know if there is anything else,
Thank you.

@ObsidianReviewBot ObsidianReviewBot added Ready for review Changes made and removed Changes requested Minor changes requested PR can be merged after some final changes have been requested labels Jul 5, 2024
@joethei joethei merged commit 287ea12 into obsidianmd:master Jul 5, 2024
1 check passed
@joycode-hub joycode-hub deleted the patch-2 branch July 5, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants