Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add theme: Gummy-Revived #3783

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Add theme: Gummy-Revived #3783

merged 1 commit into from
Jul 8, 2024

Conversation

WinnerWind
Copy link
Contributor

I am submitting a new Community Theme

Repo URL

Link to my theme: https://github.com/WinnerWind/gummy-revived

Theme checklist

  • My repo contains all required files (please do not add them to this obsidian-releases repo).
    • manifest.json
    • theme.css
    • The screenshot file (16:9 aspect ratio, recommended size is 512px by 288px for fast loading).
  • I have indicated which modes (dark, light, or both) are compatible with my theme.
  • I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my theme's adherence to these policies.
  • I have read the tips in https://docs.obsidian.md/Themes/App+themes/Theme+guidelines and have self-reviewed my theme to avoid these common pitfalls.
  • I have added a license in the LICENSE file.
  • My project respects and is compatible with the original license of any code from other themes that I'm using. I have given proper attribution to these other themes in my README.md.

Copy link

Hello!

I found the following issues in your theme submission

Errors:

❌ Could not parse community-css-themes.json, invalid JSON. Unexpected token { in JSON at position 47668


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@WinnerWind
Copy link
Contributor Author

I'm still writing the README. I need some time.

Copy link

Hello!

I found the following issues in your theme submission

Errors:

❌ Theme name mismatch, the name in this PR (Gummy-Revived) is not the same as the one in your repo (gummy). If you just changed your theme name, remember to change it in the manifest.json in your repo, and your latest GitHub release, if you have one.
❌ The theme screenshot cannot be found.


Warnings:

⚠️ Your repository does not have issues enabled. Users will not be able to report bugs and request features.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@github-actions github-actions bot changed the title Add Gummy Revived Theme Add theme: Gummy-Revived Jun 28, 2024
@WinnerWind WinnerWind closed this Jun 28, 2024
@WinnerWind WinnerWind reopened this Jun 28, 2024
Copy link

Hello!

I found the following issues in your theme submission

Errors:

❌ Theme name mismatch, the name in this PR (Gummy-Revived) is not the same as the one in your repo (Gummy Revived). If you just changed your theme name, remember to change it in the manifest.json in your repo, and your latest GitHub release, if you have one.
❌ Your theme screenshot is too big, we generally recommend a size around 512 × 288 pixels.
Detected size: 1918 x 994 pixels


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@WinnerWind WinnerWind closed this Jun 28, 2024
@WinnerWind WinnerWind reopened this Jun 28, 2024
Copy link

Hello!

I found the following issues in your theme submission

Warnings:

⚠️ Theme theme screenshot size is not optimal, we generally recommend a size around 512 × 288 pixels.
Detected size: 512 x 228 pixels


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@WinnerWind
Copy link
Contributor Author

This is now ready to be reviewed.

@WinnerWind WinnerWind marked this pull request as ready for review June 28, 2024 10:03
@joethei
Copy link
Collaborator

joethei commented Jun 28, 2024

Please add a higher res screenshot in the README.

@WinnerWind
Copy link
Contributor Author

Added an image in the Readme file. Do check it out and let me know if it is satisfactory

@WinnerWind WinnerWind closed this Jun 28, 2024
@WinnerWind WinnerWind reopened this Jun 28, 2024
Copy link

github-actions bot commented Jul 3, 2024

Hello!

I found the following issues in your theme submission

Warnings:

⚠️ Theme theme screenshot size is not optimal, we generally recommend a size around 512 × 288 pixels.
Detected size: 512 x 228 pixels


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

Copy link

github-actions bot commented Jul 8, 2024

Hello!

I found the following issues in your theme submission

Warnings:

⚠️ Theme theme screenshot size is not optimal, we generally recommend a size around 512 × 288 pixels.
Detected size: 512 x 228 pixels


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@joethei joethei merged commit 0638c90 into obsidianmd:master Jul 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants