Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin: Dinox Sync #3782

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

ryzencool
Copy link

I am submitting a new Community Plugin

Repo URL

Link to my plugin: https://github.com/ryzencool/dinox-sync

Release Checklist

  • I have tested the plugin on

    • Windows
    • macOS
    • Linux
    • Android (if applicable)
    • iOS (if applicable)
  • My GitHub release contains all required files

    • main.js
    • manifest.json
    • styles.css (optional)
  • GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)

  • The id in my manifest.json matches the id in the community-plugins.json file.

  • My README.md describes the plugin's purpose and provides clear usage instructions.

  • I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.

  • I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.

  • I have added a license in the LICENSE file.

  • My project respects and is compatible with the original license of any code from other plugins that I'm using.
    I have given proper attribution to these other projects in my README.md.

Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ Unable to find a release with the tag 1.0.0. Make sure that the version in your manifest.json file in your repo points to the correct Github Release.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

ryzencool

This comment was marked as abuse.

@ryzencool ryzencool closed this Jun 27, 2024
@ryzencool ryzencool reopened this Jun 27, 2024
Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ Unable to find a release with the tag 1.0.0. Make sure that the version in your manifest.json file in your repo points to the correct Github Release.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@ryzencool ryzencool closed this Jun 27, 2024
@ryzencool ryzencool reopened this Jun 27, 2024
Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ Your latest Release is missing the main.js file.
❌ Your latest Release is missing the manifest.json file.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@ObsidianReviewBot
Copy link
Collaborator

Thank you for your submission, an automated scan of your plugin code's revealed the following issues:


Optional

[1]:Obsidian provides the requestUrl method, it will make sure that network requests work on every plattform.


Do NOT open a new PR for re-validation.

@joethei
Copy link
Collaborator

joethei commented Jul 3, 2024

"minAppVersion": "0.15.0",
You are using newer API's, set this to the latest public build number.

const resp = await fetch(
Use the requestUrl function from the Obsidian API instead, it will handle some things like CORS automatically.

setName("Dinox Token"), .setName("Allow Auto Synchronize")
Use sentence case in UI

console.log(value);, console.log("Switch toggled to " + value);
Please avoid unnecessary logging. If you need it for debugging purposes, add a check to only log during development.

this.fetchData().then(() => {
prefer async/await over Promise

@joethei joethei added Changes requested Minor changes requested PR can be merged after some final changes have been requested and removed Ready for review labels Jul 3, 2024
Copy link

github-actions bot commented Aug 3, 2024

Hi there, as this PR has not seen any activity in the last 30 days, it will be closed in 15 days unless there are any updates.

@github-actions github-actions bot added the stale label Aug 3, 2024
@github-actions github-actions bot removed the stale label Aug 5, 2024
@ryzencool
Copy link
Author

@joethei what should I do next step?

Copy link

Hi there, as this PR has not seen any activity in the last 30 days, it will be closed in 15 days unless there are any updates.

@github-actions github-actions bot added the stale label Sep 17, 2024
@joethei
Copy link
Collaborator

joethei commented Sep 17, 2024

You haven't made all the requested changes, and there are some more places in your code with unnecessary console.log and not all of the strings are using sentence case either.

@github-actions github-actions bot removed the stale label Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes requested Minor changes requested PR can be merged after some final changes have been requested plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants