Add plugin: Iconic

[gfxholo]

I am submitting a new Community Plugin

Repo URL

Link to my plugin: https://github.com/gfxholo/iconic

Release Checklist

• I have tested the plugin on
  • Windows
  • macOS
  • Linux
  • Android (if applicable)
  • iOS (if applicable)
• My GitHub release contains all required files
  • main.js
  • manifest.json
  • styles.css (optional)
• GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
• The id in my manifest.json matches the id in the community-plugins.json file.
• My README.md describes the plugin's purpose and provides clear usage instructions.
• I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.
• I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
• I have added a license in the LICENSE file.
• My project respects and is compatible with the original license of any code from other plugins that I'm using.
  I have given proper attribution to these other projects in my README.md.

[ObsidianReviewBot]

Thank you for your submission, an automated scan of your plugin code's revealed the following issues:

Required

[1]:You should avoid assigning styles via JavaScript or in HTML and instead move all these styles into CSS so that they are more easily adaptable by themes and snippets.

---

Optional

[1][2][3]:Casting to any should be avoided as much as possible.

---

Do NOT open a new PR for re-validation.
Once you have pushed all of the required changes to your repo, the bot will update the labels on this PR within 6 hours.
If you think some of the required changes are incorrect, please comment with /skip and the reason why you think the results are incorrect.

[gfxholo]

/skip

Thanks bot! I was expecting these two points to come up.

1. This plugin sets the stroke attribute on individual SVGs to support custom hex colors, which can't really be achieved using hardcoded CSS. It also sets a filter attribute on emojis for the same reason.
2. There are 3 casts to any in the codebase:
   • 2 in IconPicker.ts to fetch a localization string using a color ID, which is guaranteed to be valid.
   • 1 in IconicSettingTab.ts to avoid some type-checking on an object full of button components, which are always assigned before their first use.

The casts can be rewritten in other ways, so let me know if they seem too egregious.

[gfxholo]

Big thanks for reviewing this, @joethei 💜