Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin: Heading Path #3776

Closed
wants to merge 3 commits into from
Closed

Add plugin: Heading Path #3776

wants to merge 3 commits into from

Conversation

19msb
Copy link
Contributor

@19msb 19msb commented Jun 27, 2024

I am submitting a new Community Plugin

Repo URL

Link to my plugin: https://github.com/19msb/obsidian-heading-path

Release Checklist

  • I have tested the plugin on
    • Windows
    • macOS
    • Linux
    • Android (if applicable)
    • iOS (if applicable)
  • My GitHub release contains all required files
    • main.js
    • manifest.json
    • styles.css (optional)
  • GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
  • The id in my manifest.json matches the id in the community-plugins.json file.
  • My README.md describes the plugin's purpose and provides clear usage instructions.
  • I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.
  • I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
  • I have added a license in the LICENSE file.
  • My project respects and is compatible with the original license of any code from other plugins that I'm using.
    I have given proper attribution to these other projects in my README.md.

@github-actions github-actions bot changed the title Add Plugin: Heading Path Add plugin: Heading Path Jun 27, 2024
@ObsidianReviewBot
Copy link
Collaborator

Thank you for your submission, an automated scan of your plugin code's revealed the following issues:

Required

[1]:Please remove the main.js file from the repo and add it to your .gitignore. Compiled release files shouldn't get mixed with source code in your commits and should go to the releases files instead.


Do NOT open a new PR for re-validation.
Once you have pushed all of the required changes to your repo, the bot will update the labels on this PR within 6 hours.
If you think some of the required changes are incorrect, please comment with /skip and the reason why you think the results are incorrect.

@ObsidianReviewBot ObsidianReviewBot self-assigned this Jun 28, 2024
@ObsidianReviewBot ObsidianReviewBot added Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made and removed Ready for review labels Jun 28, 2024
@19msb
Copy link
Contributor Author

19msb commented Jun 28, 2024

@joethei
Hope you're well.
The bot flagged main.js as not meant to be in my repo despite it being the file containing all of my source code.

@ObsidianReviewBot ObsidianReviewBot added Ready for review and removed Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made labels Jun 28, 2024
@ObsidianReviewBot ObsidianReviewBot removed their assignment Jun 28, 2024
@ObsidianReviewBot
Copy link
Collaborator

Changes requested by bot have been made, assigning human for additional review.

@joethei
Copy link
Collaborator

joethei commented Jul 2, 2024

this.developerMode = this.app.vault.getConfig('developerMode') || false;
"developerMode" does not exist.

const editor = this.app.workspace.getActiveViewOfType(MarkdownView)?.editor;
To get the active editor use this.app.workspace.activeEditor?.editor
This will also work in Canvas.

containerEl.createEl('h1', { text: 'Custom concatenation' });
Don't add a top-level heading in the settings tab, such as "General", "Settings", or the name of your plugin.

const span1s = default_stringContainer.createEl('span', {
All the .style assignments should be moved into CSS.

span1p.style.color = '#aaaaaa'; // Correct hexadecimal color value, span2p.style.color = '#aaaaaa';
And this color will cause issues in dark mode.

containerEl.createEl('h1', { text: 'Handle LaTeX' });
For section headings in settings use:

new Setting(containerEl).setName('name here').setHeading();

@joethei joethei added Changes requested Minor changes requested PR can be merged after some final changes have been requested and removed Ready for review labels Jul 2, 2024
Copy link

github-actions bot commented Aug 2, 2024

Hi there, as this PR has not seen any activity in the last 30 days, it will be closed in 15 days unless there are any updates.

@github-actions github-actions bot added the stale label Aug 2, 2024
Copy link

Hi there, to keep things tidy, we're closing PRs after one and a half months of inactivity.
Feel free to create a new pull request when you're ready to continue. Thanks for your understanding!

@github-actions github-actions bot closed this Aug 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes requested Minor changes requested PR can be merged after some final changes have been requested plugin stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants