Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin: ImgBB Uploader #3773

Merged
merged 1 commit into from
Sep 2, 2024
Merged

Conversation

jordanhandy
Copy link
Contributor

I am submitting a new Community Plugin

Repo URL

Link to my plugin: https://github.com/jordanhandy/obsidian-imgbb-uploader

Release Checklist

  • I have tested the plugin on
    • Windows
    • macOS
    • Linux
    • Android (if applicable)
    • iOS (if applicable)
  • My GitHub release contains all required files
    • main.js
    • manifest.json
    • styles.css (optional)
  • GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
  • The id in my manifest.json matches the id in the community-plugins.json file.
  • My README.md describes the plugin's purpose and provides clear usage instructions.
  • I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.
  • I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
  • I have added a license in the LICENSE file.
  • My project respects and is compatible with the original license of any code from other plugins that I'm using.
    I have given proper attribution to these other projects in my README.md.

@github-actions github-actions bot changed the title Add ImgBB Uploader plugin Add plugin: ImgBB Uploader Jun 25, 2024
@ObsidianReviewBot
Copy link
Collaborator

The automated review has not found any issues with your code, assigning human for additional review.

@joethei joethei added Changes requested Minor changes requested PR can be merged after some final changes have been requested and removed Ready for review labels Jul 2, 2024
@jordanhandy
Copy link
Contributor Author

Hi @joethei
Is point 1 still required since requestUrl doesn't support FormData? A pain to have to convert to either string or ArrayBuffer. Axios makes this process much simpler

Points 2 and 3 are noted.

Copy link

github-actions bot commented Aug 2, 2024

Hi there, as this PR has not seen any activity in the last 30 days, it will be closed in 15 days unless there are any updates.

@github-actions github-actions bot added the stale label Aug 2, 2024
@jordanhandy
Copy link
Contributor Author

Hi @joethei
Bumping this as its been over a month since the last comment.

I've fixed the issue you mentioned above. Settings UI now uses sentence case.
I've opted not to use requestUrl because of the lack of its support for multipart form data (see here https://github.com/obsidianmd/obsidian-api/issues/150)

Thanks

@ObsidianReviewBot ObsidianReviewBot added Ready for review Changes made and removed Changes requested Minor changes requested PR can be merged after some final changes have been requested labels Aug 6, 2024
@github-actions github-actions bot removed the stale label Sep 2, 2024
@joethei joethei merged commit db94b4e into obsidianmd:master Sep 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants