Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this MR is to move to fabric8io docker maven plugin as spotify docker maven plugin is no longer maintained and doesn't provide arm64 compatibility.
With the given setup, one can change the base image using property -Ddocker.base.image while building.
eclipse-temurin
doesn't have arm64 compatible manifest as of now but has arm images underarm64v8/eclipse-temurin
.Also github workflows have runners based on amd64 processors while circleci has runners available for both arm64 and amd64 machines.
So in all it would be a tough setup to provide arm compatible images but this MR would still help someone who is building locally.
On the other hand in my fork I can work on to provide an arm64 compatible counterpart of kafdrop in the interim a solution is being discovered.