Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added login page #282

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

added login page #282

wants to merge 5 commits into from

Conversation

johnneal3
Copy link

I have a requirement on my end to secure access to Kafdrop via a login page. I am submitting this code for your review / approval. This is a simple login solution, only supporting a single user.

Default:

  • username = admin
  • password = admin

Override via command line args (validated in docker/docker-compose as well):

java --add-opens=java.base/sun.nio.ch=ALL-UNNAMED    \
     -jar target/kafdrop-3.28.0-SNAPSHOT.jar \
      --kafka.brokerConnect=localhost:29092    \
      --spring.security.user.name=fred --spring.security.user.password=mary

image

@lgtm-com
Copy link

lgtm-com bot commented May 24, 2021

This pull request introduces 1 alert when merging bed6777 into fdc887a - view on LGTM.com

new alerts:

  • 1 for Disabled Spring CSRF protection

johnneal3 and others added 4 commits May 24, 2021 16:33
@johnneal3
removed dependency on csrf.disable()
6199bc0
@johnneal3
issue when setting context path
b7ea24a
@johnneal3
Update topic-create.ftlh
832276b 
corrected issue caused by enabling http.csrf() that was not caught in initial testing.
@johnneal3
fixed delete topic issue
1e9143a 
fixed issue with delete topic after http.csrf() was enabled with addition of login screen
@xtruan
Copy link

xtruan commented Dec 10, 2021

I have tested this enhancement (verifying login prompt, creating topics, deleting topics, etc.) at my organization and we have incorporated into our Kafdrop instance. Thanks!

@rachitnovostack rachitnovostack mentioned this pull request Dec 21, 2021
Closed
@Hongten
Copy link

Hongten commented Jul 29, 2024

How about using Google Auth to log in to the system?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johnneal3 @xtruan @Hongten