generated from obsidianmd/obsidian-sample-plugin
-
-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add date-picker to the Edit Task modal #3169
Merged
claremacrae
merged 16 commits into
obsidian-tasks-group:main
from
ilandikov:feat-date-picker-in-modal
Nov 4, 2024
Merged
feat: Add date-picker to the Edit Task modal #3169
claremacrae
merged 16 commits into
obsidian-tasks-group:main
from
ilandikov:feat-date-picker-in-modal
Nov 4, 2024
+107
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quality Gate passedIssues Measures |
claremacrae
changed the title
feat: date picker in Edit Task modal
feat: Add date-picker to the Edit Task modal
Nov 4, 2024
claremacrae
approved these changes
Nov 4, 2024
I've added a short video of it in action, on a Mac. |
Brilliant - thank you @ilandikov! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Done by pairing with @claremacrae
Changes visible to users:
feat
- non-breaking change which adds functionality)Description
getAndCheckRenderedElement()
)Motivation and Context
How has this been tested?
Screenshots (if appropriate)
Date.Picker.in.EDit.Task.Modal.mp4
Checklist
yarn run lint
.Terms