Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add date-picker to the Edit Task modal #3169

Merged

Conversation

ilandikov
Copy link
Collaborator

@ilandikov ilandikov commented Nov 4, 2024

Types of changes

Done by pairing with @claremacrae

Changes visible to users:

Description

  • add date picker for the dates in the Edit Task modal
  • fix helper function testing that an element has been rendered (getAndCheckRenderedElement())

Motivation and Context

  • Quicker way to select dates in the Edit Task modal

How has this been tested?

  • Unit tests
  • Exploratory testing

Screenshots (if appropriate)

Date.Picker.in.EDit.Task.Modal.mp4

Checklist

Terms

@ilandikov ilandikov added the scope: edit task The Create or edit task modal/dialog label Nov 4, 2024
Copy link

sonarcloud bot commented Nov 4, 2024

@claremacrae claremacrae changed the title feat: date picker in Edit Task modal feat: Add date-picker to the Edit Task modal Nov 4, 2024
@claremacrae
Copy link
Collaborator

I've added a short video of it in action, on a Mac.

@claremacrae claremacrae merged commit 1461ba4 into obsidian-tasks-group:main Nov 4, 2024
2 checks passed
@claremacrae
Copy link
Collaborator

Brilliant - thank you @ilandikov!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: edit task The Create or edit task modal/dialog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants